Add analyze endpoint to rust driver #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnangovindraj
changed the title
krishnangovindraj
requested review from
dmitrii-ubskii and
flyingsilverfin
as code owners
krishnangovindraj
force-pushed
the
grpc-query-structure
branch
from
45b06c2 to
3705f44
Compare
flyingsilverfin
force-pushed
the
master
branch
2 times, most recently
from
0cb6566 to
570fd60
Compare
krishnangovindraj
changed the base branch from
master
to
feature/grpc-driver-analyze
Comment on lines
+147
to
+179
| #[repr(C)] | ||
| #[derive(Debug, Clone)] | ||
| pub enum Comparator { | ||
| Equal, | ||
| NotEqual, | ||
| LessThan, | ||
| LessOrEqual, | ||
| Greater, | ||
| GreaterOrEqual, | ||
| Like, | ||
| Contains, | ||
| } |
Member
Author
There was a problem hiding this comment.
Should we just keep things simple and use a string?
krishnangovindraj
force-pushed
the
grpc-query-structure
branch
from
5a822d2 to
1cc50b2
Compare
rust/src/common/error.rs
Outdated
| 35: "TLS connections can only be enabled when connecting to HTTPS endpoints, for example using 'https://<ip>:port'. Please modify the address, or disable TLS (WARNING: this will send passwords over plaintext).", | ||
| NonTlsConnectionWithHttps = | ||
| 36: "Connecting to an https endpoint requires enabling TLS in driver options.", | ||
| AnalyzeQueryNoResponse = |
flyingsilverfin
approved these changes
Oct 20, 2025
Member
flyingsilverfin
left a comment
flyingsilverfin
left a comment
There was a problem hiding this comment.
Looks good!
my only fear is now the docs API page is gonna get bigger but that feels like a docs representation problem not a source code problem!
| /// as well as the result of types inferred for each variable by type-inference. | ||
| #[derive(Debug, Clone)] | ||
| pub struct AnalyzedQuery { | ||
| pub source: String, |
| } | ||
|
|
||
| // | ||
| // impl TryFromProto<analyze_proto::Fetch> for Fetch { |
flyingsilverfin
approved these changes
Oct 21, 2025
Member
flyingsilverfin
left a comment
flyingsilverfin
left a comment
There was a problem hiding this comment.
CHeck comments but approval stands
krishnangovindraj
merged commit a6ea6d9
into
typedb:feature/grpc-driver-analyze
6 of 9 checks passed
krishnangovindraj
added a commit
that referenced
this pull request
Nov 10, 2025
## Usage and product changes Adds support for the analyze endpoint to rust driver. ## Implementation Implement protocol serialization/deserialization and request/response handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
Adds support for the analyze endpoint to rust driver.
Implementation
Implement protocol serialization/deserialization and request/response handling.